Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WALL] [Fix] Rostislav / WALL-3092 / Fix transfer ATM fields position on mobile #12240

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[WALL] [Fix] Rostislav / WALL-3092 / Fix transfer ATM fields position on mobile #12240

merged 1 commit into from
Dec 14, 2023

Conversation

rostislav-deriv
Copy link
Contributor

Changes:

  • make the ATM inputs stick to the bottom on mobile

review-deriv
review-deriv reviewed Dec 13, 2023
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 13, 2023 3:18pm

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12240](https://github.com/binary-com/deriv-app/pull/12240)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rostislav-deriv-rostislav-fix-mobile-b79aba.binary.sx?qa_server=red.derivws.com&app_id=23847
    - **Original**: https://deriv-app-git-fork-rostislav-deriv-rostislav-fix-mobile-b79aba.binary.sx
- **App ID**: `23847`

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-fix-mobile-b79aba.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 31.392%. remained the same
when pulling a2be566 on rostislav-deriv:rostislav/fix-mobile-transfer-inputs-position
into 7b17ce1 on binary-com:master.

@nijil-deriv nijil-deriv merged commit ab9c987 into deriv-com:master Dec 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@review-deriv review-deriv review-deriv left review comments

@wojciech-deriv wojciech-deriv wojciech-deriv approved these changes

@heorhi-deriv heorhi-deriv heorhi-deriv approved these changes

@matin-deriv matin-deriv matin-deriv approved these changes

@nijil-deriv nijil-deriv nijil-deriv approved these changes

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

@aizad-deriv aizad-deriv Awaiting requested review from aizad-deriv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rostislav-deriv @coveralls @nijil-deriv @matin-deriv @heorhi-deriv @wojciech-deriv @review-deriv